Eric Biggers 930787c9cd crypto: ablkcipher - fix crash flushing dcache in error path ... commit 318abdfbe708aaaa652c79fb500e9bd60521f9dc upstream. Like the skcipher_walk and blkcipher_walk cases: scatterwalk_done() is only meant to be called after a nonzero number of bytes have been processed, since scatterwalk_pagedone() will flush the dcache of the *previous* page. But in the error case of ablkcipher_walk_done(), e.g. if the input wasn't an integer number of blocks, scatterwalk_done() was actually called after advancing 0 bytes. This caused a crash ("BUG: unable to handle kernel paging request") during '!PageSlab(page)' on architectures like arm and arm64 that define ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE, provided that the input was page-aligned as in that case walk->offset == 0. Fix it by reorganizing ablkcipher_walk_done() to skip the scatterwalk_advance() and scatterwalk_done() if an error has occurred. Reported-by: Liu Chao <liuchao741@huawei.com> Fixes: bf06099db1 ("crypto: skcipher - Add ablkcipher_walk interfaces") Cc: <stable@vger.kernel.org> # v2.6.35+ Signed-off-by: Eric Biggers <ebiggers@google.com> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2018-08-17 20:56:45 +02:00
..
asymmetric_keys	X.509: reject invalid BIT STRING for subjectPublicKey	2017-12-16 10:33:48 +01:00
async_tx	async_tx: Fix DMA_PREP_FENCE usage in do_async_gen_syndrome()	2018-04-13 19:50:06 +02:00
.gitignore
842.c
ablk_helper.c
ablkcipher.c	crypto: ablkcipher - fix crash flushing dcache in error path	2018-08-17 20:56:45 +02:00
aead.c	crypto: aead - Remove CRYPTO_ALG_AEAD_NEW flag	2015-08-17 16:53:53 +08:00
aes_generic.c
af_alg.c	crypto: af_alg - fix possible uninit-value in alg_bind()	2018-05-16 10:06:49 +02:00
ahash.c	crypto: ahash - Fix early termination in hash walk	2018-04-08 11:52:00 +02:00
akcipher.c	crypto: akcipher - Don't #include crypto/public_key.h as the contents aren't used	2015-10-20 22:14:01 +08:00
algapi.c	crypto: algapi - fix NULL dereference in crypto_remove_spawns()	2018-01-17 09:35:30 +01:00
algboss.c	crypto: algboss - Remove reference to nivaead	2015-08-17 16:53:41 +08:00
algif_aead.c	crypto: algif_aead - Require setkey before accept(2)	2017-05-20 14:27:00 +02:00
algif_hash.c	crypto: algif_hash - avoid zero-sized array	2017-03-30 09:35:20 +02:00
algif_rng.c
algif_skcipher.c	crypto: AF_ALG - remove SGL terminator indicator when chaining	2017-09-27 11:00:14 +02:00
ansi_cprng.c
anubis.c
api.c	crypto: api - Only abort operations on fatal signal	2015-10-20 21:59:25 +08:00
arc4.c
authenc.c	crypto: authenc - don't leak pointers to authenc keys	2018-08-06 16:24:39 +02:00
authencesn.c	crypto: authencesn - don't leak pointers to authenc keys	2018-08-06 16:24:39 +02:00
blkcipher.c	crypto: blkcipher - fix crash flushing dcache in error path	2018-08-17 20:56:45 +02:00
blowfish_common.c
blowfish_generic.c
camellia_generic.c
cast_common.c
cast5_generic.c
cast6_generic.c
cbc.c
ccm.c	crypto: replace scatterwalk_sg_chain with sg_chain	2015-08-17 08:12:54 -06:00
chacha20_generic.c
chacha20poly1305.c	crypto: chacha20poly1305 - validate the digest size	2018-01-10 09:27:09 +01:00
chainiv.c
cipher.c
cmac.c
compress.c
crc32.c
crc32c_generic.c	crypto: crc32c - Fix crc32c soft dependency	2016-02-17 12:31:04 -08:00
crct10dif_common.c
crct10dif_generic.c
cryptd.c	crypto: cryptd - pass through absence of ->setkey()	2018-02-16 20:09:43 +01:00
crypto_null.c
crypto_user.c	crypto: user - re-add size check for CRYPTO_MSG_GETALG	2016-07-11 09:31:12 -07:00
crypto_wq.c
ctr.c
cts.c
deflate.c
des_generic.c
drbg.c
ecb.c
echainiv.c	crypto: echainiv - Replace chaining with multiplication	2016-09-30 10:18:34 +02:00
eseqiv.c
fcrypt.c
fips.c
gcm.c	crypto: gcm - wait for crypto op not signal safe	2017-06-14 13:16:21 +02:00
gf128mul.c
ghash-generic.c	crypto: ghash-generic - move common definitions to a new header file	2016-10-22 12:26:56 +02:00
hash_info.c
hmac.c	crypto: hmac - require that the underlying hash algorithm is unkeyed	2017-12-20 10:04:51 +01:00
internal.h
jitterentropy-kcapi.c	crypto: jitterentropy - remove unnecessary information from a comment	2015-10-14 22:23:16 +08:00
jitterentropy.c
Kconfig	Revert "crypto: xts - Add ECB dependency"	2017-11-21 09:21:22 +01:00
keywrap.c	crypto: keywrap - memzero the correct memory	2016-04-12 09:08:45 -07:00
khazad.c
lrw.c
lz4.c
lz4hc.c
lzo.c
Makefile	crypto: improve gcc optimization flags for serpent and wp512	2017-03-18 19:09:56 +08:00
mcryptd.c	crypto: mcryptd - protect the per-CPU queue with a lock	2018-01-02 20:33:19 +01:00
md4.c
md5.c
memneq.c
michael_mic.c
pcbc.c
pcompress.c
pcrypt.c	crypto: pcrypt - fix freeing pcrypt instances	2018-01-10 09:27:09 +01:00
poly1305_generic.c	crypto: poly1305 - remove ->setkey() method	2018-02-16 20:09:43 +01:00
proc.c
ripemd.h
rmd128.c
rmd160.c
rmd256.c
rmd320.c
rng.c
rsa_helper.c	crypto: akcipher - Changes to asymmetric key API	2015-10-14 22:23:16 +08:00
rsa.c	crypto: akcipher - Changes to asymmetric key API	2015-10-14 22:23:16 +08:00
rsaprivkey.asn1	crypto: akcipher - Changes to asymmetric key API	2015-10-14 22:23:16 +08:00
rsapubkey.asn1	crypto: akcipher - Changes to asymmetric key API	2015-10-14 22:23:16 +08:00
salsa20_generic.c	crypto: salsa20 - fix blkcipher_walk API usage	2017-12-20 10:04:51 +01:00
scatterwalk.c	crypto: scatterwalk - Fix test in scatterwalk_done	2016-08-16 09:30:50 +02:00
seed.c
seqiv.c	crypto: seqiv - Use generic geniv init/exit helpers	2015-08-17 16:53:46 +08:00
serpent_generic.c
sha1_generic.c
sha256_generic.c
sha512_generic.c
shash.c	crypto: hmac - require that the underlying hash algorithm is unkeyed	2017-12-20 10:04:51 +01:00
skcipher.c	crypto: skcipher - Add crypto_skcipher_has_setkey	2016-02-17 12:31:03 -08:00
tcrypt.c	crypto: tcrypt - fix S/G table for test_aead_speed()	2018-02-16 20:09:38 +01:00
tcrypt.h
tea.c
testmgr.c	crypto: testmgr - fix out of bound read in __test_aead()	2017-05-02 21:19:48 -07:00
testmgr.h	crypto: testmgr - Pad aes_ccm_enc_tv_template vector	2017-03-12 06:37:28 +01:00
tgr192.c
twofish_common.c
twofish_generic.c
vmac.c	crypto: vmac - separate tfm and request context	2018-08-17 20:56:45 +02:00
wp512.c
xcbc.c
xor.c
xts.c
zlib.c