Sebastian Andrzej Siewior 2e234e707f crypto: mcryptd - protect the per-CPU queue with a lock ... commit 9abffc6f2efe46c3564c04312e52e07622d40e51 upstream. mcryptd_enqueue_request() grabs the per-CPU queue struct and protects access to it with disabled preemption. Then it schedules a worker on the same CPU. The worker in mcryptd_queue_worker() guards access to the same per-CPU variable with disabled preemption. If we take CPU-hotplug into account then it is possible that between queue_work_on() and the actual invocation of the worker the CPU goes down and the worker will be scheduled on _another_ CPU. And here the preempt_disable() protection does not work anymore. The easiest thing is to add a spin_lock() to guard access to the list. Another detail: mcryptd_queue_worker() is not processing more than MCRYPTD_BATCH invocation in a row. If there are still items left, then it will invoke queue_work() to proceed with more later. *I* would suggest to simply drop that check because it does not use a system workqueue and the workqueue is already marked as "CPU_INTENSIVE". And if preemption is required then the scheduler should do it. However if queue_work() is used then the work item is marked as CPU unbound. That means it will try to run on the local CPU but it may run on another CPU as well. Especially with CONFIG_DEBUG_WQ_FORCE_RR_CPU=y. Again, the preempt_disable() won't work here but lock which was introduced will help. In order to keep work-item on the local CPU (and avoid RR) I changed it to queue_work_on(). Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2018-01-02 20:33:19 +01:00
..
asymmetric_keys	X.509: reject invalid BIT STRING for subjectPublicKey	2017-12-16 10:33:48 +01:00
async_tx	async_pq_val: fix DMA memory leak	2016-10-22 12:26:55 +02:00
.gitignore	crypto: rsa - add .gitignore for crypto/*.-asn1.[ch] files	2015-06-25 23:29:24 +08:00
842.c	crypto: 842 - change 842 alg to use software	2015-05-11 15:06:43 +08:00
ablk_helper.c	crypto: cryptd - process CRYPTO_ALG_INTERNAL	2015-03-31 21:21:04 +08:00
ablkcipher.c	crypto: skcipher - Copy iv from desc even for 0-len walks	2015-12-09 20:16:22 +08:00
aead.c	crypto: aead - Remove CRYPTO_ALG_AEAD_NEW flag	2015-08-17 16:53:53 +08:00
aes_generic.c
af_alg.c	crypto: af_alg - Forbid bind(2) when nokey child sockets are present	2016-02-17 12:31:04 -08:00
ahash.c	crypto: ahash - Fix EINPROGRESS notification callback	2017-04-21 09:30:06 +02:00
akcipher.c	crypto: akcipher - Don't #include crypto/public_key.h as the contents aren't used	2015-10-20 22:14:01 +08:00
algapi.c	crypto: api - Clear CRYPTO_ALG_DEAD bit before registering an alg	2017-02-09 08:02:44 +01:00
algboss.c	crypto: algboss - Remove reference to nivaead	2015-08-17 16:53:41 +08:00
algif_aead.c	crypto: algif_aead - Require setkey before accept(2)	2017-05-20 14:27:00 +02:00
algif_hash.c	crypto: algif_hash - avoid zero-sized array	2017-03-30 09:35:20 +02:00
algif_rng.c	crypto: algif_rng - Remove obsolete const-removal cast	2015-04-22 09:30:21 +08:00
algif_skcipher.c	crypto: AF_ALG - remove SGL terminator indicator when chaining	2017-09-27 11:00:14 +02:00
ansi_cprng.c	crypto: ansi_cprng - Convert to new rng interface	2015-04-22 09:30:18 +08:00
anubis.c
api.c	crypto: api - Only abort operations on fatal signal	2015-10-20 21:59:25 +08:00
arc4.c
authenc.c	crypto: aead - Remove CRYPTO_ALG_AEAD_NEW flag	2015-08-17 16:53:53 +08:00
authencesn.c	crypto: authencesn - Fix digest_null crash	2017-08-06 19:19:39 -07:00
blkcipher.c	crypto: skcipher - Fix blkcipher walk OOM crash	2016-09-30 10:18:34 +02:00
blowfish_common.c
blowfish_generic.c
camellia_generic.c
cast5_generic.c
cast6_generic.c
cast_common.c
cbc.c
ccm.c	crypto: replace scatterwalk_sg_chain with sg_chain	2015-08-17 08:12:54 -06:00
chacha20_generic.c	crypto: chacha20 - Export common ChaCha20 helpers	2015-07-17 21:20:21 +08:00
chacha20poly1305.c	crypto: aead - Remove CRYPTO_ALG_AEAD_NEW flag	2015-08-17 16:53:53 +08:00
chainiv.c	crypto: chainiv - Offer normal cipher functionality without RNG	2015-06-22 15:49:28 +08:00
cipher.c
cmac.c
compress.c
crc32.c
crc32c_generic.c	crypto: crc32c - Fix crc32c soft dependency	2016-02-17 12:31:04 -08:00
crct10dif_common.c
crct10dif_generic.c
cryptd.c	crypto: cryptd - Assign statesize properly	2017-03-26 12:13:17 +02:00
crypto_null.c	crypto: null - Add default null skcipher	2015-05-22 11:25:55 +08:00
crypto_user.c	crypto: user - re-add size check for CRYPTO_MSG_GETALG	2016-07-11 09:31:12 -07:00
crypto_wq.c
ctr.c
cts.c
deflate.c
des_generic.c
drbg.c	crypto: drbg - report backend_cra_name when allocation fails	2015-06-11 21:55:28 +08:00
ecb.c
echainiv.c	crypto: echainiv - Replace chaining with multiplication	2016-09-30 10:18:34 +02:00
eseqiv.c	crypto: eseqiv - Offer normal cipher functionality without RNG	2015-06-22 15:49:28 +08:00
fcrypt.c
fips.c	crypto: fips - Move fips_enabled sysctl into fips.c	2015-04-23 14:18:09 +08:00
gcm.c	crypto: gcm - wait for crypto op not signal safe	2017-06-14 13:16:21 +02:00
gf128mul.c
ghash-generic.c	crypto: ghash-generic - move common definitions to a new header file	2016-10-22 12:26:56 +02:00
hash_info.c
hmac.c	crypto: hmac - require that the underlying hash algorithm is unkeyed	2017-12-20 10:04:51 +01:00
internal.h	crypto: api - Remove linux/fips.h from internal.h	2015-04-23 14:18:10 +08:00
jitterentropy-kcapi.c	crypto: jitterentropy - remove unnecessary information from a comment	2015-10-14 22:23:16 +08:00
jitterentropy.c	crypto: jitterentropy - Delete unnecessary checks before the function call "kzfree"	2015-06-25 23:18:33 +08:00
Kconfig	Revert "crypto: xts - Add ECB dependency"	2017-11-21 09:21:22 +01:00
keywrap.c	crypto: keywrap - memzero the correct memory	2016-04-12 09:08:45 -07:00
khazad.c
lrw.c
lz4.c
lz4hc.c
lzo.c
Makefile	crypto: improve gcc optimization flags for serpent and wp512	2017-03-18 19:09:56 +08:00
mcryptd.c	crypto: mcryptd - protect the per-CPU queue with a lock	2018-01-02 20:33:19 +01:00
md4.c
md5.c	crypto: md5 - use md5 IV MD5_HX instead of their raw value	2015-05-18 12:20:18 +08:00
memneq.c
michael_mic.c
pcbc.c
pcompress.c	crypto: pcomp - Use crypto_alg_extsize helper	2015-04-21 10:19:55 +08:00
pcrypt.c	crypto: aead - Remove CRYPTO_ALG_AEAD_NEW flag	2015-08-17 16:53:53 +08:00
poly1305_generic.c	crypto: poly1305 - Export common Poly1305 helpers	2015-07-17 21:20:26 +08:00
proc.c	crypto: fips - Move fips_enabled sysctl into fips.c	2015-04-23 14:18:09 +08:00
ripemd.h
rmd128.c
rmd160.c
rmd256.c	crypto: prefix module autoloading with "crypto-"	2014-11-24 22:43:57 +08:00
rmd320.c
rng.c	crypto: rng - Do not free default RNG when it becomes unused	2015-06-22 15:49:18 +08:00
rsa_helper.c	crypto: akcipher - Changes to asymmetric key API	2015-10-14 22:23:16 +08:00
rsa.c	crypto: akcipher - Changes to asymmetric key API	2015-10-14 22:23:16 +08:00
rsaprivkey.asn1	crypto: akcipher - Changes to asymmetric key API	2015-10-14 22:23:16 +08:00
rsapubkey.asn1	crypto: akcipher - Changes to asymmetric key API	2015-10-14 22:23:16 +08:00
salsa20_generic.c	crypto: salsa20 - fix blkcipher_walk API usage	2017-12-20 10:04:51 +01:00
scatterwalk.c	crypto: scatterwalk - Fix test in scatterwalk_done	2016-08-16 09:30:50 +02:00
seed.c
seqiv.c	crypto: seqiv - Use generic geniv init/exit helpers	2015-08-17 16:53:46 +08:00
serpent_generic.c
sha1_generic.c	crypto: sha1-generic - move to generic glue implementation	2015-04-10 21:39:40 +08:00
sha256_generic.c	crypto: sha256-generic - move to generic glue implementation	2015-04-10 21:39:41 +08:00
sha512_generic.c	crypto: sha512-generic - move to generic glue implementation	2015-04-10 21:39:41 +08:00
shash.c	crypto: hmac - require that the underlying hash algorithm is unkeyed	2017-12-20 10:04:51 +01:00
skcipher.c	crypto: skcipher - Add crypto_skcipher_has_setkey	2016-02-17 12:31:03 -08:00
tcrypt.c	crypto: tcrypt - fix buffer lengths in test_aead_speed()	2017-12-20 10:04:58 +01:00
tcrypt.h	crypto: tcrypt - Add ChaCha20/Poly1305 speed tests	2015-07-17 21:20:20 +08:00
tea.c
testmgr.c	crypto: testmgr - fix out of bound read in __test_aead()	2017-05-02 21:19:48 -07:00
testmgr.h	crypto: testmgr - Pad aes_ccm_enc_tv_template vector	2017-03-12 06:37:28 +01:00
tgr192.c
twofish_common.c
twofish_generic.c
vmac.c
wp512.c
xcbc.c
xor.c
xts.c
zlib.c	crypto: pcomp - Constify (de)compression parameters	2015-05-01 11:16:37 +08:00