Liwei Song 3abc229cfc i2c: ismt: fix wrong device address when unmap the data buffer ... commit 17e83549e199d89aace7788a9f11c108671eecf5 upstream. Fix the following kernel bug: kernel BUG at drivers/iommu/intel-iommu.c:3260! invalid opcode: 0000 [#5] PREEMPT SMP Hardware name: Intel Corp. Harcuvar/Server, BIOS HAVLCRB0.X64.0013.D39.1608311820 08/31/2016 task: ffff880175389950 ti: ffff880176bec000 task.ti: ffff880176bec000 RIP: 0010:[<ffffffff8150a83b>] [<ffffffff8150a83b>] intel_unmap+0x25b/0x260 RSP: 0018:ffff880176bef5e8 EFLAGS: 00010296 RAX: 0000000000000024 RBX: ffff8800773c7c88 RCX: 000000000000ce04 RDX: 0000000080000000 RSI: 0000000000000000 RDI: 0000000000000009 RBP: ffff880176bef638 R08: 0000000000000010 R09: 0000000000000004 R10: ffff880175389c78 R11: 0000000000000a4f R12: ffff8800773c7868 R13: 00000000ffffac88 R14: ffff8800773c7818 R15: 0000000000000001 FS: 00007fef21258700(0000) GS:ffff88017b5c0000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 000000000066d6d8 CR3: 000000007118c000 CR4: 00000000003406e0 Stack: 00000000ffffac88 ffffffff8199867f ffff880176bef5f8 ffff880100000030 ffff880176bef668 ffff8800773c7c88 ffff880178288098 ffff8800772c0010 ffff8800773c7818 0000000000000001 ffff880176bef648 ffffffff8150a86e Call Trace: [<ffffffff8199867f>] ? printk+0x46/0x48 [<ffffffff8150a86e>] intel_unmap_page+0xe/0x10 [<ffffffffa039d99b>] ismt_access+0x27b/0x8fa [i2c_ismt] [<ffffffff81554420>] ? __pm_runtime_suspend+0xa0/0xa0 [<ffffffff815544a0>] ? pm_suspend_timer_fn+0x80/0x80 [<ffffffff81554420>] ? __pm_runtime_suspend+0xa0/0xa0 [<ffffffff815544a0>] ? pm_suspend_timer_fn+0x80/0x80 [<ffffffff8143dfd0>] ? pci_bus_read_dev_vendor_id+0xf0/0xf0 [<ffffffff8172b36c>] i2c_smbus_xfer+0xec/0x4b0 [<ffffffff810aa4d5>] ? vprintk_emit+0x345/0x530 [<ffffffffa038936b>] i2cdev_ioctl_smbus+0x12b/0x240 [i2c_dev] [<ffffffff810aa829>] ? vprintk_default+0x29/0x40 [<ffffffffa0389b33>] i2cdev_ioctl+0x63/0x1ec [i2c_dev] [<ffffffff811b04c8>] do_vfs_ioctl+0x328/0x5d0 [<ffffffff8119d8ec>] ? vfs_write+0x11c/0x190 [<ffffffff8109d449>] ? rt_up_read+0x19/0x20 [<ffffffff811b07f1>] SyS_ioctl+0x81/0xa0 [<ffffffff819a351b>] system_call_fastpath+0x16/0x6e This happen When run "i2cdetect -y 0" detect SMBus iSMT adapter. After finished I2C block read/write, when unmap the data buffer, a wrong device address was pass to dma_unmap_single(). To fix this, give dma_unmap_single() the "dev" parameter, just like what dma_map_single() does, then unmap can find the right devices. Fixes: 13f35ac14c ("i2c: Adding support for Intel iSMT SMBus 2.0 host controller") Signed-off-by: Liwei Song <liwei.song@windriver.com> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> Signed-off-by: Wolfram Sang <wsa@the-dreams.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2018-08-17 20:56:44 +02:00
..
accessibility
acpi	ACPI / LPSS: Add missing prv_offset setting for byt/cht PWM devices	2018-08-15 17:42:05 +02:00
amba	ARM: amba: Don't read past the end of sysfs "driver_override" buffer	2018-05-02 07:53:42 -07:00
android	binder: add missing binder_unlock()	2018-02-28 10:17:23 +01:00
ata	libata: Fix command retry decision	2018-08-06 16:24:36 +02:00
atm	atm: zatm: Fix potential Spectre v1	2018-07-22 14:25:52 +02:00
auxdisplay
base	x86/speculation/l1tf: Add sysfs reporting for l1tf	2018-08-15 17:42:09 +02:00
bcma
block	loop: remember whether sysfs_create_group() was done	2018-07-17 11:31:46 +02:00
bluetooth	Bluetooth: btusb: Add a new Realtek 8723DE ID 2ff8:b011	2018-08-06 16:24:32 +02:00
bus	bus: brcmstb_gisb: correct support for 64-bit address output	2018-04-13 19:50:05 +02:00
cdrom	cdrom: do not call check_disk_change() inside cdrom_open()	2018-05-30 07:49:13 +02:00
char	tpm: fix race condition in tpm_common_write()	2018-08-15 17:42:04 +02:00
clk	clk: tegra: Fix PLL_U post divider and initial rate on Tegra30	2018-07-25 10:18:32 +02:00
clocksource	clocksource/drivers/fsl_ftm_timer: Fix error return checking	2018-05-30 07:49:01 +02:00
connector
cpufreq	cpufreq: Fix new policy initialization during limits updates via sysfs	2018-07-03 11:21:26 +02:00
cpuidle	cpuidle: powernv: Fix promotion from snooze if next state disabled	2018-07-03 11:21:29 +02:00
crypto	crypto: padlock-aes - Fix Nano workaround data corruption	2018-08-06 16:24:42 +02:00
dca
devfreq	PM / devfreq: Propagate error from devfreq_add_device()	2018-02-22 15:44:58 +01:00
dio
dma	dmaengine: pxa_dma: remove duplicate const qualifier	2018-08-06 16:24:40 +02:00
dma-buf
edac	EDAC, mv64x60: Fix an error handling path	2018-04-13 19:50:23 +02:00
eisa
extcon
firewire	firewire-ohci: work around oversized DMA reads on JMicron controllers	2018-05-30 07:48:52 +02:00
firmware	firmware: dmi_scan: Fix handling of empty DMI strings	2018-05-30 07:48:56 +02:00
fmc
fpga
gpio	gpio: No NULL owner	2018-06-16 09:54:26 +02:00
gpu	drm/gma500: fix psb_intel_lvds_mode_valid()'s return type	2018-08-06 16:24:38 +02:00
hid	HID: i2c-hid: check if device is there before really probing	2018-08-06 16:24:36 +02:00
hsi	HSI: ssi_protocol: double free in ssip_pn_xmit()	2018-03-24 10:58:42 +01:00
hv	Drivers: hv: vmbus: fix build warning	2018-02-25 11:03:46 +01:00
hwmon	hwmon: (pmbus/adm1275) Accept negative page register values	2018-05-30 07:49:13 +02:00
hwspinlock
hwtracing	hwtracing: stm: fix build error on some arches	2018-06-06 16:46:23 +02:00
i2c	i2c: ismt: fix wrong device address when unmap the data buffer	2018-08-17 20:56:44 +02:00
ide	cdrom: do not call check_disk_change() inside cdrom_open()	2018-05-30 07:49:13 +02:00
idle	idle: i7300: add PCI dependency	2018-02-25 11:03:51 +01:00
iio	iio:buffer: make length types match kfifo types	2018-07-03 11:21:30 +02:00
infiniband	IB/ocrdma: fix out of bounds access to local buffer	2018-08-15 17:42:06 +02:00
input	Input: elan_i2c - add another ACPI ID for Lenovo Ideapad 330-15AST	2018-08-06 16:24:29 +02:00
iommu	x86/cpufeature: Remove unused and seldomly used cpu_has_xx macros	2018-06-16 09:54:24 +02:00
ipack
irqchip	irqchip/gic-v3: Change pr_debug message to pr_devel	2018-05-30 07:48:57 +02:00
isdn	isdn: eicon: fix a missing-check bug	2018-06-13 16:15:28 +02:00
leds	leds: pca955x: Correct I2C Functionality	2018-04-13 19:50:09 +02:00
lguest
lightnvm
macintosh
mailbox
mcb
md	md: fix NULL dereference of mddev->pers in remove_and_add_spares()	2018-08-06 16:24:35 +02:00
media	media: si470x: fix __be16 annotations	2018-08-06 16:24:39 +02:00
memory	memory: tegra: Apply interrupts mask per SoC	2018-08-06 16:24:38 +02:00
memstick
message	scsi: mptfusion: Add bounds check in mptctl_hp_targetinfo()	2018-05-30 07:48:58 +02:00
mfd	mfd: cros_ec: Fail early if we cannot identify the EC	2018-08-06 16:24:32 +02:00
misc	vmw_balloon: fix inflation with batching	2018-07-17 11:31:43 +02:00
mmc	mmc: sdhci-iproc: fix 32bit writes for TRANSFER_MODE register	2018-05-30 07:48:51 +02:00
mtd	mtd: rawnand: fsl_ifc: fix FSL NAND driver to read all ONFI parameter pages	2018-08-06 16:24:36 +02:00
net	xen/netfront: don't cache skb_shinfo()	2018-08-15 17:42:05 +02:00
nfc	NFC: nfcmrvl: double free on error path	2018-03-22 09:23:23 +01:00
ntb	ntb_transport: Fix bug with max_mw_size parameter	2018-05-30 07:48:55 +02:00
nubus
nvdimm	linvdimm, pmem: Preserve read-only setting for pmem devices	2018-07-03 11:21:31 +02:00
nvme	nvme-pci: initialize queue memory before interrupts	2018-07-11 16:03:47 +02:00
nvmem
of	of: unittest: for strings, account for trailing \0 in property length field	2018-07-03 11:21:29 +02:00
oprofile
parisc	parisc/pci: Switch LBA PCI bus from Hard Fail to Soft Fail mode	2018-05-30 07:49:10 +02:00
parport	parport_pc: Add support for WCH CH382L PCI-E single parallel port card.	2018-04-08 11:52:00 +02:00
pci	ACPI / PCI: Bail early in acpi_pci_add_bus() if there is no ACPI handle	2018-08-09 12:19:28 +02:00
pcmcia
perf	drivers/perf: arm_pmu: handle no platform_device	2018-03-22 09:23:26 +01:00
phy
pinctrl	pinctrl: at91-pio4: add missing of_node_put	2018-08-06 16:24:34 +02:00
platform	platform/chrome: Use proper protocol transfer function	2018-03-24 10:58:47 +01:00
pnp
power	power: supply: pda_power: move from timer to delayed_work	2018-03-24 10:58:45 +01:00
powercap	PowerCap: Fix an error code in powercap_register_zone()	2018-04-13 19:50:05 +02:00
pps
ps3
ptp	ptp: fix missing break in switch	2018-07-25 10:18:17 +02:00
pwm	pwm: tegra: Increase precision in PWM rate calculation	2018-03-22 09:23:27 +01:00
rapidio
ras
regulator	regulator: pfuze100: add .is_enable() for pfuze100_swb_regulator_ops	2018-08-06 16:24:35 +02:00
remoteproc
reset
rpmsg
rtc	rtc: ensure rtc_set_alarm fails when alarms are not supported	2018-08-06 16:24:30 +02:00
s390	scsi: zfcp: fix missing REC trigger trace on enqueue without ERP thread	2018-07-03 11:21:31 +02:00
sbus
scsi	scsi: sr: Avoid that opening a CD-ROM hangs with runtime power management enabled	2018-08-15 17:42:05 +02:00
sfi
sh
sn
soc
spi	spi: Fix scatterlist elements size in spi_map_buf	2018-07-03 11:21:35 +02:00
spmi
ssb	ssb: mark ssb_bus_register as __maybe_unused	2018-02-25 11:03:44 +01:00
staging	staging: comedi: quatech_daqp_cs: fix no-op loop daqp_ao_insn_write()	2018-07-11 16:03:51 +02:00
target	tcm_fileio: Prevent information leak for short reads	2018-03-24 10:58:45 +01:00
tc
thermal	thermal: exynos: fix setting rising_threshold for Exynos5433	2018-08-06 16:24:37 +02:00
thunderbolt	thunderbolt: Resume control channel after hibernation image is created	2018-04-24 09:32:07 +02:00
tty	tty: Fix data race in tty_insert_flip_string_fixed_flag	2018-08-06 16:24:36 +02:00
uio
usb	usb: hub: Don't wait for connect state at resume for powered-off ports	2018-08-06 16:24:39 +02:00
uwb
vfio	vfio/pci: Virtualize Maximum Read Request Size	2018-04-24 09:32:09 +02:00
vhost	vhost_net: validate sock before trying to put its fd	2018-07-22 14:25:53 +02:00
video	video: uvesafb: Fix integer overflow in allocation	2018-07-03 11:21:34 +02:00
virt
virtio	virtio_balloon: fix another race between migration and ballooning	2018-08-06 16:24:42 +02:00
vlynq
vme
w1	1wire: family module autoload fails because of upper/lower case mismatch.	2018-07-03 11:21:27 +02:00
watchdog	watchdog: f71808e_wdt: Fix magic close handling	2018-05-30 07:49:03 +02:00
xen	xen: Remove unnecessary BUG_ON from __unbind_from_irq()	2018-07-03 11:21:34 +02:00
zorro	zorro: Set up z->dev.dma_mask for the DMA API	2018-05-30 07:49:11 +02:00
Kconfig
Makefile	usb: build drivers/usb/common/ when USB_SUPPORT is set	2018-02-25 11:03:38 +01:00