a7y18lte-ubports/android_kernel_samsung_universal7885
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

sysfs: move struct sysfs_dirent to private header

Browse Source 
struct sysfs_dirent is private to the fs/sysfs/ subtree.  It is
not even referenced as an opaque structure outside of that subtree.

The following patch moves the declaration from include/linux/sysfs.h to
fs/sysfs/sysfs.h, making it clearer that nothing else in the kernel
dereferences it.

I have been running this patch for years.  Please integrate and forward
upstream if there are no objections.

From: "Adam J. Richter" <adam@yggdrasil.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
Adam J. Richter 2007-02-16 21:35:25 +08:00 committed by Greg Kroah-Hartman
parent 63ce18cfe6
commit d56c3eae67
2 changed files with 12 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
fs/sysfs/sysfs.h
View File

@ -1,3 +1,14 @@
struct sysfs_dirent {
atomic_t s_count;
struct list_head s_sibling;
struct list_head s_children;
void * s_element;
int s_type;
umode_t s_mode;
struct dentry * s_dentry;
struct iattr * s_iattr;
atomic_t s_event;
};
extern struct vfsmount * sysfs_mount; extern struct vfsmount * sysfs_mount;
extern struct kmem_cache *sysfs_dir_cachep; extern struct kmem_cache *sysfs_dir_cachep;

13
include/linux/sysfs.h
View File

@ -17,6 +17,7 @@
struct kobject; struct kobject;
struct module; struct module;
struct nameidata; struct nameidata;
struct dentry;
struct attribute { struct attribute {
const char * name; const char * name;
@ -68,18 +69,6 @@ struct sysfs_ops {
ssize_t (*store)(struct kobject *,struct attribute *,const char *, size_t); ssize_t (*store)(struct kobject *,struct attribute *,const char *, size_t);
}; };
struct sysfs_dirent {
atomic_t s_count;
struct list_head s_sibling;
struct list_head s_children;
void * s_element;
int s_type;
umode_t s_mode;
struct dentry * s_dentry;
struct iattr * s_iattr;
atomic_t s_event;
};
#define SYSFS_ROOT 0x0001 #define SYSFS_ROOT 0x0001
#define SYSFS_DIR 0x0002 #define SYSFS_DIR 0x0002
#define SYSFS_KOBJ_ATTR 0x0004 #define SYSFS_KOBJ_ATTR 0x0004