a7y18lte-ubports/android_kernel_samsung_universal7885
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ipv4: fix NULL checking in devinet_ioctl()

Browse Source 
The NULL pointer check `!ifa' should come before its first use.

[ Bug origin : commit fd23c3b311
  (ipv4: Add hash table of interface addresses) in linux-2.6.39 ]

Signed-off-by: Xi Wang <xi.wang@gmail.com>
Acked-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Xi Wang 2013-01-05 11:19:24 +00:00 committed by David S. Miller
parent ae62ca7b03
commit c7e2e1d72e
1 changed files with 1 additions and 1 deletions

2
net/ipv4/devinet.c
View File

@ -823,9 +823,9 @@ int devinet_ioctl(struct net *net, unsigned int cmd, void __user *arg)
if (!ifa) { if (!ifa) {
ret = -ENOBUFS; ret = -ENOBUFS;
ifa = inet_alloc_ifa(); ifa = inet_alloc_ifa();
INIT_HLIST_NODE(&ifa->hash);
if (!ifa) if (!ifa)
break; break;
INIT_HLIST_NODE(&ifa->hash);
if (colon) if (colon)
memcpy(ifa->ifa_label, ifr.ifr_name, IFNAMSIZ); memcpy(ifa->ifa_label, ifr.ifr_name, IFNAMSIZ);
else else