a7y18lte-ubports/android_kernel_samsung_universal7885
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

rtnetlink: unlock on error path in netlink_dump()

Browse Source 
In c7ac8679bec939 "rtnetlink: Compute and store minimum ifinfo dump
size", we moved the allocation under the lock so we need to unlock
on error path.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: David S. Miller <davem@conan.davemloft.net>
This commit is contained in:
Dan Carpenter 2011-06-15 03:11:42 +00:00 committed by David S. Miller
parent 59deab26c1
commit c63d6ea306
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
net/netlink/af_netlink.c
View File

@ -1676,7 +1676,7 @@ static int netlink_dump(struct sock *sk)
skb = sock_rmalloc(sk, alloc_size, 0, GFP_KERNEL); skb = sock_rmalloc(sk, alloc_size, 0, GFP_KERNEL);
if (!skb) if (!skb)
goto errout; goto errout_skb;
len = cb->dump(skb, cb); len = cb->dump(skb, cb);
@ -1716,7 +1716,6 @@ static int netlink_dump(struct sock *sk)
errout_skb: errout_skb:
mutex_unlock(nlk->cb_mutex); mutex_unlock(nlk->cb_mutex);
kfree_skb(skb); kfree_skb(skb);
errout:
return err; return err;
} }