a7y18lte-ubports/android_kernel_samsung_universal7885
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mfd: ab8500-debugfs: Cleaning up unnecessary to test, unsigned can't be negative.

Browse Source 
Unsigned variable can't be negative so it is unnecessary to test it

This was found using a static code analysis program called cppcheck

Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
This commit is contained in:
Rickard Strandqvist 2014-06-28 23:34:38 +02:00 committed by Lee Jones
parent 005d16b602
commit a3dd01e177
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/mfd/ab8500-debugfs.c
View File

@ -2503,7 +2503,7 @@ static ssize_t ab8500_gpadc_trig_timer_write(struct file *file,
if (err) if (err)
return err; return err;
if ((user_trig_timer >= 0) && (user_trig_timer <= 255)) { if (user_trig_timer <= 255) {
trig_timer = (u8) user_trig_timer; trig_timer = (u8) user_trig_timer;
} else { } else {
dev_err(dev, "debugfs error input: " dev_err(dev, "debugfs error input: "