a7y18lte-ubports/android_kernel_samsung_universal7885
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

inet: remove old fragmentation hash initializing

Browse Source 
All fragmentation hash secrets now get initialized by their
corresponding hash function with net_get_random_once. Thus we can
eliminate the initial seeding.

Also provide a comment that hash secret seeding happens at the first
call to the corresponding hashing function.

Cc: David S. Miller <davem@davemloft.net>
Cc: Eric Dumazet <edumazet@google.com>
Signed-off-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Hannes Frederic Sowa 2013-10-23 11:06:57 +02:00 committed by David S. Miller
parent b1190570b4
commit 7088ad74e6
2 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
include/net/inet_frag.h
View File

@ -64,6 +64,10 @@ struct inet_frags {
rwlock_t lock ____cacheline_aligned_in_smp; rwlock_t lock ____cacheline_aligned_in_smp;
int secret_interval; int secret_interval;
struct timer_list secret_timer; struct timer_list secret_timer;
/* The first call to hashfn is responsible to initialize
* rnd. This is best done with net_get_random_once.
*/
u32 rnd; u32 rnd;
int qsize; int qsize;

3
net/ipv4/inet_fragment.c
View File

@ -93,9 +93,6 @@ void inet_frags_init(struct inet_frags *f)
} }
rwlock_init(&f->lock); rwlock_init(&f->lock);
f->rnd = (u32) ((totalram_pages ^ (totalram_pages >> 7)) ^
(jiffies ^ (jiffies >> 6)));
setup_timer(&f->secret_timer, inet_frag_secret_rebuild, setup_timer(&f->secret_timer, inet_frag_secret_rebuild,
(unsigned long)f); (unsigned long)f);
f->secret_timer.expires = jiffies + f->secret_interval; f->secret_timer.expires = jiffies + f->secret_interval;