a7y18lte-ubports/android_kernel_samsung_universal7885
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

msi-wmi: Fix memory leak

Browse Source 
Fix memory leak - don't forget to kfree ACPI object when returning from
msi_wmi_notify() after suppressing key event.

Signed-off-by: Maxim Mikityanskiy <maxtram95@gmail.com>
Acked-by: Anisse Astier <anisse@astier.eu>
Signed-off-by: Lee, Chun-Yi <jlee@suse.com>
Signed-off-by: Matthew Garrett <matthew.garrett@nebula.com>
This commit is contained in:
Maxim Mikityanskiy 2012-12-15 19:31:31 +02:00 committed by Matthew Garrett
parent 03696e51d7
commit 51c94491c8
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/platform/x86/msi-wmi.c
View File

@ -176,7 +176,7 @@ static void msi_wmi_notify(u32 value, void *context)
pr_debug("Suppressed key event 0x%X - " pr_debug("Suppressed key event 0x%X - "
"Last press was %lld us ago\n", "Last press was %lld us ago\n",
key->code, ktime_to_us(diff)); key->code, ktime_to_us(diff));
return; goto msi_wmi_notify_exit;
} }
last_pressed[key->code - SCANCODE_BASE] = cur; last_pressed[key->code - SCANCODE_BASE] = cur;
@ -195,6 +195,8 @@ static void msi_wmi_notify(u32 value, void *context)
pr_info("Unknown key pressed - %x\n", eventcode); pr_info("Unknown key pressed - %x\n", eventcode);
} else } else
pr_info("Unknown event received\n"); pr_info("Unknown event received\n");
msi_wmi_notify_exit:
kfree(response.pointer); kfree(response.pointer);
} }