a7y18lte-ubports/android_kernel_samsung_universal7885
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Staging: bcm: Remove unneeded else after return.

Browse Source 
The following patch fixes the checkpatch.pl warning:
WARNING: else is generally not useful after a break or return.

Signed-off-by: Heena Sirwani <heenasirwani@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Heena Sirwani 2014-09-22 15:44:01 +05:30 committed by Greg Kroah-Hartman
parent 522c15ee37
commit 38bb617449
1 changed files with 6 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
drivers/staging/bcm/Bcmchar.c
View File

@ -564,9 +564,8 @@ static int bcm_char_ioctl_gpio_set_request(void __user *argp,
BCM_DEBUG_PRINT(ad, DBG_TYPE_OTHERS, OSAL_DBG, DBG_LVL_ALL, BCM_DEBUG_PRINT(ad, DBG_TYPE_OTHERS, OSAL_DBG, DBG_LVL_ALL,
"GPIO_MODE_REGISTER read failed"); "GPIO_MODE_REGISTER read failed");
return status; return status;
} else {
status = STATUS_SUCCESS;
} }
status = STATUS_SUCCESS;
/* Set the gpio mode register to output */ /* Set the gpio mode register to output */
*(UINT *)reset_val |= (1<<bit); *(UINT *)reset_val |= (1<<bit);
@ -673,9 +672,8 @@ static int bcm_char_ioctl_gpio_status_request(void __user *argp,
BCM_DEBUG_PRINT(ad, DBG_TYPE_PRINTK, 0, 0, BCM_DEBUG_PRINT(ad, DBG_TYPE_PRINTK, 0, 0,
"RDM Failed\n"); "RDM Failed\n");
return status; return status;
} else {
status = STATUS_SUCCESS;
} }
status = STATUS_SUCCESS;
return status; return status;
} }
@ -766,9 +764,8 @@ static int bcm_char_ioctl_gpio_multi_request(void __user *argp,
BCM_DEBUG_PRINT(ad, DBG_TYPE_PRINTK, 0, 0, BCM_DEBUG_PRINT(ad, DBG_TYPE_PRINTK, 0, 0,
"RDM to GPIO_PIN_STATE_REGISTER Failed."); "RDM to GPIO_PIN_STATE_REGISTER Failed.");
return status; return status;
} else {
status = STATUS_SUCCESS;
} }
status = STATUS_SUCCESS;
pgpio_multi_info[WIMAX_IDX].uiGPIOValue = pgpio_multi_info[WIMAX_IDX].uiGPIOValue =
(*(UINT *)reset_val & (*(UINT *)reset_val &
@ -822,9 +819,8 @@ static int bcm_char_ioctl_gpio_mode_request(void __user *argp,
BCM_DEBUG_PRINT(ad, DBG_TYPE_PRINTK, 0, 0, BCM_DEBUG_PRINT(ad, DBG_TYPE_PRINTK, 0, 0,
"Read of GPIO_MODE_REGISTER failed"); "Read of GPIO_MODE_REGISTER failed");
return status; return status;
} else {
status = STATUS_SUCCESS;
} }
status = STATUS_SUCCESS;
/* Validating the request */ /* Validating the request */
if (IsReqGpioIsLedInNVM(ad, pgpio_multi_mode[WIMAX_IDX].uiGPIOMask) if (IsReqGpioIsLedInNVM(ad, pgpio_multi_mode[WIMAX_IDX].uiGPIOMask)
@ -1079,10 +1075,9 @@ static int bcm_char_ioctl_buffer_download_stop(void __user *argp,
up(&ad->fw_download_sema); up(&ad->fw_download_sema);
up(&ad->NVMRdmWrmLock); up(&ad->NVMRdmWrmLock);
return status; return status;
} else {
BCM_DEBUG_PRINT(ad, DBG_TYPE_OTHERS, OSAL_DBG,
DBG_LVL_ALL, "Firm Download Over...\n");
} }
BCM_DEBUG_PRINT(ad, DBG_TYPE_OTHERS, OSAL_DBG,
DBG_LVL_ALL, "Firm Download Over...\n");
mdelay(10); mdelay(10);