a7y18lte-ubports/android_kernel_samsung_universal7885
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

drivers/misc/phantom.c: add missing warning messages in phantom_probe()

Browse Source 
phantom_probe() can fail in many places.  Add missing warning messages in
pci_enable_device() and pci_request_regions().

Signed-off-by: Rahul Ruikar <rahul.ruikar@gmail.com>
Cc: Jiri Slaby <jirislaby@gmail.com>
Cc: Greg KH <greg@kroah.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Rahul Ruikar 2010-10-26 14:22:35 -07:00 committed by Linus Torvalds
parent ca1cab37d9
commit 10ad5278bb
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/misc/phantom.c
View File

@ -343,8 +343,10 @@ static int __devinit phantom_probe(struct pci_dev *pdev,
int retval; int retval;
retval = pci_enable_device(pdev); retval = pci_enable_device(pdev);
if (retval) if (retval) {
dev_err(&pdev->dev, "pci_enable_device failed!\n");
goto err; goto err;
}
minor = phantom_get_free(); minor = phantom_get_free();
if (minor == PHANTOM_MAX_MINORS) { if (minor == PHANTOM_MAX_MINORS) {
@ -356,8 +358,10 @@ static int __devinit phantom_probe(struct pci_dev *pdev,
phantom_devices[minor] = 1; phantom_devices[minor] = 1;
retval = pci_request_regions(pdev, "phantom"); retval = pci_request_regions(pdev, "phantom");
if (retval) if (retval) {
dev_err(&pdev->dev, "pci_request_regions failed!\n");
goto err_null; goto err_null;
}
retval = -ENOMEM; retval = -ENOMEM;
pht = kzalloc(sizeof(*pht), GFP_KERNEL); pht = kzalloc(sizeof(*pht), GFP_KERNEL);