a7y18lte-ubports/android_kernel_samsung_universal7885
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[PATCH] kill_pid_info: kill acquired_tasklist_lock

Browse Source 
Kill acquired_tasklist_lock, sig_needs_tasklist() is very cheap nowadays.

Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Oleg Nesterov 2007-02-10 01:44:56 -08:00 committed by Linus Torvalds
parent b963a8441c
commit 0c12b51712
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
kernel/signal.c
View File

@ -1119,19 +1119,18 @@ kill_pg_info(int sig, struct siginfo *info, pid_t pgrp)
int kill_pid_info(int sig, struct siginfo *info, struct pid *pid) int kill_pid_info(int sig, struct siginfo *info, struct pid *pid)
{ {
int error; int error;
int acquired_tasklist_lock = 0;
struct task_struct *p; struct task_struct *p;
rcu_read_lock(); rcu_read_lock();
if (unlikely(sig_needs_tasklist(sig))) { if (unlikely(sig_needs_tasklist(sig)))
read_lock(&tasklist_lock); read_lock(&tasklist_lock);
acquired_tasklist_lock = 1;
}
p = pid_task(pid, PIDTYPE_PID); p = pid_task(pid, PIDTYPE_PID);
error = -ESRCH; error = -ESRCH;
if (p) if (p)
error = group_send_sig_info(sig, info, p); error = group_send_sig_info(sig, info, p);
if (unlikely(acquired_tasklist_lock))
if (unlikely(sig_needs_tasklist(sig)))
read_unlock(&tasklist_lock); read_unlock(&tasklist_lock);
rcu_read_unlock(); rcu_read_unlock();
return error; return error;