a7y18lte-ubports/android_kernel_samsung_universal7885
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

nfsd: Modify nfsd4_cb_sec to use kuids and kgids

Browse Source 
Change uid and gid in struct nfsd4_cb_sec to be of type kuid_t and
kgid_t.

In nfsd4_decode_cb_sec when reading uids and gids off the wire convert
them to kuids and kgids, and if they don't convert to valid kuids or
valid kuids ignore RPC_AUTH_UNIX and don't fill in any of the fields.

Cc: "J. Bruce Fields" <bfields@fieldses.org>
Cc: Trond Myklebust <Trond.Myklebust@netapp.com>
Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
This commit is contained in:
Eric W. Biederman 2013-02-02 06:24:49 -08:00
parent ab8e4aee0a
commit 03bc6d1cc1
2 changed files with 12 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
fs/nfsd/nfs4xdr.c
View File

@ -464,9 +464,16 @@ static __be32 nfsd4_decode_cb_sec(struct nfsd4_compoundargs *argp, struct nfsd4_
READ32(dummy); READ32(dummy);
READ_BUF(dummy * 4); READ_BUF(dummy * 4);
if (cbs->flavor == (u32)(-1)) { if (cbs->flavor == (u32)(-1)) {
cbs->uid = uid; kuid_t kuid = make_kuid(&init_user_ns, uid);
cbs->gid = gid; kgid_t kgid = make_kgid(&init_user_ns, gid);
cbs->flavor = RPC_AUTH_UNIX; if (uid_valid(kuid) && gid_valid(kgid)) {
cbs->uid = kuid;
cbs->gid = kgid;
cbs->flavor = RPC_AUTH_UNIX;
} else {
dprintk("RPC_AUTH_UNIX with invalid"
"uid or gid ignoring!\n");
}
} }
break; break;
case RPC_AUTH_GSS: case RPC_AUTH_GSS:

4
fs/nfsd/state.h
View File

@ -152,8 +152,8 @@ struct nfsd4_channel_attrs {
struct nfsd4_cb_sec { struct nfsd4_cb_sec {
u32 flavor; /* (u32)(-1) used to mean "no valid flavor" */ u32 flavor; /* (u32)(-1) used to mean "no valid flavor" */
u32 uid; kuid_t uid;
u32 gid; kgid_t gid;
}; };
struct nfsd4_create_session { struct nfsd4_create_session {