From e9f8f27b51df8f6b26c1f9961737996e8c5f6d66 Mon Sep 17 00:00:00 2001 From: Bhushan Shah Date: Mon, 25 Feb 2019 20:29:00 +0000 Subject: [PATCH] linux-purism-librem5dev: Disable CONFIG_FW_LOADER_USER_HELPER (!237) When working on Librem5 devkit we had issue with touchscreen driver not probing fast enough and taking ~70 seconds to finish initialization. Touchscreen driver for the Librem5 devkit uses goodix driver, roughly speaking device initialization is done in following sequence, - start kernel and load driver - attempt to request firmware - if no firmware is found use defaults value - initialize touchscreen Now, on Librem 5 no firmware is provided (of course!) which makes 2nd step 4 step process, - attempt to load firmware at initramfs level - fail, wait for it userspace to finish loading - userspace attempts to load firmware - fail and tell kernel to stop looking for firmware. Step 2 to 4 is done after udev is loaded in userspace, which easily takes 40-50 seconds. Since Purism Librem 5 devkit is never going to have userspace level firmware, it is safe bet to disable this altogether. [skip ci] tested locally and this is going to take more then hour on CI and fail --- device/linux-purism-librem5dev/APKBUILD | 4 ++-- .../linux-purism-librem5dev/config-purism-librem5dev.aarch64 | 3 +-- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/device/linux-purism-librem5dev/APKBUILD b/device/linux-purism-librem5dev/APKBUILD index 7e7033159..5b425899a 100644 --- a/device/linux-purism-librem5dev/APKBUILD +++ b/device/linux-purism-librem5dev/APKBUILD @@ -3,7 +3,7 @@ pkgname="linux-purism-librem5dev" pkgver=4.18.11 -pkgrel=1 +pkgrel=2 pkgdesc="Purism Librem 5 devkit kernel fork" arch="aarch64" _carch="arm64" @@ -73,4 +73,4 @@ package() { } sha512sums="51fd07402e63ce7538e65c01deba51faaf60cbb853d0af2d362aceb710e608d0cdee4b53524d32b4217b7da7cc827270c427207e7bd34b8b5f87b43791aa81db linux-purism-librem5dev-bcc9a4658624009ce94abeb19b1be07b55d6da21.tar.gz -e8871767aac7895de98769e70b6eef791a78d3eb41c73570e35dd82795e89f1da2eaa96014abf54c50ba6bae55ac02c1aea19ca40a0ded3bd23560fdedb3e932 config-purism-librem5dev.aarch64" +b5d9f27826355814479cad9673452bc648733b3779c2856eed7d60127c8cd83cdf3c23ad2fab6c81a1adf05ef2d14dac36250053cfa2e730659059e5bdb7c093 config-purism-librem5dev.aarch64" diff --git a/device/linux-purism-librem5dev/config-purism-librem5dev.aarch64 b/device/linux-purism-librem5dev/config-purism-librem5dev.aarch64 index 22b5043c3..afa00799e 100644 --- a/device/linux-purism-librem5dev/config-purism-librem5dev.aarch64 +++ b/device/linux-purism-librem5dev/config-purism-librem5dev.aarch64 @@ -1099,8 +1099,7 @@ CONFIG_PREVENT_FIRMWARE_BUILD=y # CONFIG_FW_LOADER=y CONFIG_EXTRA_FIRMWARE="" -CONFIG_FW_LOADER_USER_HELPER=y -CONFIG_FW_LOADER_USER_HELPER_FALLBACK=y +# CONFIG_FW_LOADER_USER_HELPER is not set CONFIG_WANT_DEV_COREDUMP=y CONFIG_ALLOW_DEV_COREDUMP=y CONFIG_DEV_COREDUMP=y