a71-pmos/pmaports-a71
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
master
pmaports-a71/.ci/lib/apkbuild_linting.py

27 lines
802 B
Python
Raw Permalink Normal View History

CI: skip linting check for temp/ folder (!864) Since we copy these aports directly from Alpine and try to keep them in sync, we don't want to differ from upstream because our CI doesn't pass on linting. If the APKBUILD should be improved, it should be done upstream which is then synced back to us.
2020-01-06 17:25:27 +00:00
#!/usr/bin/env python3
# SPDX-License-Identifier: GPL-3.0-or-later
import common
CI: apkbuild-linting: use get_changed_files() instead of get_changed_packages() (!1069) For APKBUILD linting we care only about APKBUILD files that were changed, not to which package they belong or whatever. The "with_directory" option of get_changed_packages() really meant "just give me changed files", which means that we can just use get_changed_files() instead.
2020-03-14 11:22:08 +00:00
import os.path
CI: skip linting check for temp/ folder (!864) Since we copy these aports directly from Alpine and try to keep them in sync, we don't want to differ from upstream because our CI doesn't pass on linting. If the APKBUILD should be improved, it should be done upstream which is then synced back to us.
2020-01-06 17:25:27 +00:00
import sys
if __name__ == "__main__":
common.add_upstream_git_remote()
CI: apkbuild-linting: use get_changed_files() instead of get_changed_packages() (!1069) For APKBUILD linting we care only about APKBUILD files that were changed, not to which package they belong or whatever. The "with_directory" option of get_changed_packages() really meant "just give me changed files", which means that we can just use get_changed_files() instead.
2020-03-14 11:22:08 +00:00
apkbuilds = {file for file in common.get_changed_files(removed=False)
if os.path.basename(file) == "APKBUILD"}
if len(apkbuilds) < 1:
CI: skip linting check for temp/ folder (!864) Since we copy these aports directly from Alpine and try to keep them in sync, we don't want to differ from upstream because our CI doesn't pass on linting. If the APKBUILD should be improved, it should be done upstream which is then synced back to us.
2020-01-06 17:25:27 +00:00
print("No APKBUILDs to lint")
sys.exit(0)
CI: use a single invocation for apkbuild linting (MR 2472) This replaces the current loop calling pmbootstrap lint once for each package with a single invocation for increased performance. Here are some measurements for linting all packages under main/. Before this change: $ time .gitlab-ci/apkbuild-linting.py > /dev/null real 3m55,840s user 3m48,592s sys 0m16,913s After this change but without postmarketOS/pmbootstrap!2100: $ time .gitlab-ci/apkbuild-linting.py > /dev/null real 0m14,359s user 0m17,994s sys 0m6,488s After this change with postmarketOS/pmbootstrap!2100: $ time .gitlab-ci/apkbuild-linting.py > /dev/null real 0m6,411s user 0m13,334s sys 0m2,417s Note that postmarketOS/pmbootstrap!2100 is not required for that little bit of extra performance but rather because it allows to differentiate between linting errors for different packages in the output. Depends: postmarketOS/pmbootstrap!2100 Closes: #564
2021-08-30 09:09:02 +00:00
packages = []
CI: apkbuild-linting: use get_changed_files() instead of get_changed_packages() (!1069) For APKBUILD linting we care only about APKBUILD files that were changed, not to which package they belong or whatever. The "with_directory" option of get_changed_packages() really meant "just give me changed files", which means that we can just use get_changed_files() instead.
2020-03-14 11:22:08 +00:00
for apkbuild in apkbuilds:
if apkbuild.startswith("temp/") or apkbuild.startswith("cross/"):
print(f"NOTE: Skipping linting of {apkbuild}")
CI: skip linting check for temp/ folder (!864) Since we copy these aports directly from Alpine and try to keep them in sync, we don't want to differ from upstream because our CI doesn't pass on linting. If the APKBUILD should be improved, it should be done upstream which is then synced back to us.
2020-01-06 17:25:27 +00:00
continue
CI: use a single invocation for apkbuild linting (MR 2472) This replaces the current loop calling pmbootstrap lint once for each package with a single invocation for increased performance. Here are some measurements for linting all packages under main/. Before this change: $ time .gitlab-ci/apkbuild-linting.py > /dev/null real 3m55,840s user 3m48,592s sys 0m16,913s After this change but without postmarketOS/pmbootstrap!2100: $ time .gitlab-ci/apkbuild-linting.py > /dev/null real 0m14,359s user 0m17,994s sys 0m6,488s After this change with postmarketOS/pmbootstrap!2100: $ time .gitlab-ci/apkbuild-linting.py > /dev/null real 0m6,411s user 0m13,334s sys 0m2,417s Note that postmarketOS/pmbootstrap!2100 is not required for that little bit of extra performance but rather because it allows to differentiate between linting errors for different packages in the output. Depends: postmarketOS/pmbootstrap!2100 Closes: #564
2021-08-30 09:09:02 +00:00
packages.append(os.path.basename(os.path.dirname(apkbuild)))
ci/apkbuild-linting: quit if there are no apkbuilds to lint (MR 2630) If the only changed apkbuilds are skipped, then the check would lint *every* apkbuild in aports (calling '-q lint' with no packages apparently causes it to do everything) This quits if all packages were skipped. It fixes the CI failure seen on MR !2600
2021-10-24 07:05:02 +00:00
if len(packages) < 1:
print("No APKBUILDs to lint")
sys.exit(0)
CI: skip linting check for temp/ folder (!864) Since we copy these aports directly from Alpine and try to keep them in sync, we don't want to differ from upstream because our CI doesn't pass on linting. If the APKBUILD should be improved, it should be done upstream which is then synced back to us.
2020-01-06 17:25:27 +00:00
CI: apkbuild_linting: fix missing output (MR 5633) pmbootstrap used to exit with 0 if "pmbootstrap lint" failed. This was the case in 2.3.x too, but I assumed this was a regression and fixed it recently in pmbootstrap MR 2398. It turns out that the CI code relied on this assumption, it captured the output of "pmbootstrap lint", and only after it is done it checks if the output wasn't empty and prints it in that case followed by exit 1. Now that pmbootstrap actually exits with 1, CI already fails at "common.run_pmbootstrap" and doesn't get to the part where it would be printed. I think "exit 1" on error is actually the right thing to do in pmbootstrap, so I'll leave that in. Adjust CI to just run "pmbootstrap lint", removing the additional output capture logic that isn't used anywhere besides here. This also has the advantage that we get the output "live", without buffering it completely first.
2024-09-26 18:16:05 +00:00
common.run_pmbootstrap(["-q", "lint"] + packages)
Reference in New Issue Copy Permalink